This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
AWS ECS: validate memory + cpu pairs #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
approved these changes
Jul 15, 2021
catsby
commented
Jul 15, 2021
| @@ -1063,58 +1056,29 @@ func (p *Platform) Launch( | |||
| L.Debug("registering task definition", "id", id) | |||
|
|
|||
| var cpuShares int | |||
| family := "waypoint-" + app.App | |||
|
|
|||
| s.Status("Registering Task definition: %s", family) | |||
There was a problem hiding this comment.
Note: I moved this because it's the first status update in this method, and without moving it (or adding another one) when the validation fails it looks like the previous step failed, and not this one
evanphx
approved these changes
Jul 19, 2021
Comment on lines
+5
to
+7
| ```release-note:bug | ||
| plugin/aws/ecs: validate memory and cpu values | ||
| ``` |
There was a problem hiding this comment.
I think these should be in one block, mostly because I think go-changelog only supports one block per file?
There was a problem hiding this comment.
You can have multiple entries in a single go-changelog txt file! https://github.com/hashicorp/waypoint/blob/main/.github/CHANGELOG_GUIDE.md#multiple-entries
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS ECS / Fargate require the memory and cpu values for containers to be agreeable, and will error when trying to create a container or task definition if they do not match the prescribed values. See this article for more information:
The Waypoint ECS deployment already validated these to a point, but the ECS Server install did not. This PR refactors that validation into a shared utility and uses it for both the platform and server install.
UX for using bad memory value in an ECS deploy:
UX for using bad memory / cpu values for server install: