This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
serverinstall/k8s: update log msg and add terminal warn for RollingUpdate #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
suggested changes
Jul 19, 2021
internal/serverinstall/k8s.go
Outdated
| s.Update("Update Strategy is 'RollingUpdate'; once the upgrade completes, you may need to restart the pod to update the server image") | ||
| s.Status(terminal.StatusWarn) | ||
| s.Done() | ||
| s = sg.Add("") |
There was a problem hiding this comment.
I think we can move the s.Update checks to further below on 567:
waypoint/internal/serverinstall/k8s.go
Lines 563 to 566 in 4bc8627
But good call on the Warning, we should update ☝🏻 to be Warn
There was a problem hiding this comment.
new output
✓ Image set to update!
⚠️ Update Strategy is 'RollingUpdate'; once the upgrade completes, you may need to restart the pod to update the server image
✓ Upgrade complete!
Kubernetes is now set to upgrade waypoint server image with its
'RollingUpdate' strategy. This means the pod might not be updated immediately.
briancain
approved these changes
Jul 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1795
If a user does not specify a
-k8s-server-imageor-k8s-pull-policyon the initial install, then we default to K8S defaults, which is to use an imagePullPolicy ofAlwaysfor images taggedlatest. Rather than force a restart of the pod during awaypoint upgrade, we are adding a note in the CLI output to alert users to these settings so they can take appropriate action per their cluster settings and needs.