This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Allow disabling exec only for the entrypoint #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
changed the title
izaaklauer
suggested changes
Aug 3, 2021
izaaklauer
approved these changes
Aug 3, 2021
briancain
approved these changes
Aug 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1720
This allows the
WAYPOINT_CEB_DISABLE_EXECenv var to be set to a truthy value to disablewaypoint exec. This request is threaded through to the server so that the server should not ever assign an exec session to that instance, but also the entrypoint itself prevents any exec session if the server is poorly behaved or outdated.Docs also updated.
This also removes the
FindExecInstanceAPI. @evanphx and I agreed to remove it since it was never used. And I had to remove it for this PR since it would've had to take into account whether exec was enabled or not and rather than enhancing that API, I'd rather remove it if we were going to remove it anyways.