This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
plugin/google: several improvements related to resource management #2005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a lot but they were all interconnected so I figured it was still small enough to include in one PR, as change requests for one part may affect other parts here anyway.
Things done:
waypoint destroy
calls to specifically target the service rather than just revisions(note: there is still a bug with deployment destroys, see #2002; because of that, the first example below requires running
waypoint up
between destroy attempts in order to accurately see the errors.)Before changes:
After changes: