Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Introduce On-Demand Runners #2056

Merged
merged 51 commits into from
Aug 23, 2021
Merged

Introduce On-Demand Runners #2056

merged 51 commits into from
Aug 23, 2021

Conversation

evanphx
Copy link
Contributor

@evanphx evanphx commented Aug 16, 2021

This is a big PR and so I suggest reading it a commit at a time rather than all at once. The commits are sequenced and cohesive as standalone changes.

This change corresponds with a plugin-sdk PR as well: hashicorp/waypoint-plugin-sdk#56

This builds on the task plugin work to add the concept on an ondemand runner (or ODR). This commit covers 4 main areas:

  1. Introduction of state to register plugin types and configuration, where those fields are used to launch tasks that contain the ondemand runners.
  2. Modifications to the runner code (albiet minor) so that a runner knows it's in ODR mode AND advertises this fact to plugins, so they can operate specially if they wish.
  3. A new docker builder ODR mode that uses kaniko to execute the Docker build in the context of the runner.
  4. A new pack builder ODR mode that uses kaniko to execute the pack build in the context of the runner.

Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing the rest of this now...but figured I'd comment on these now since it's not entirely related to the rest of the PR reivew 😄

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Co-authored-by: Brian Cain <bcain@hashicorp.com>
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more code review! ✨ This looks cool 😎 excited to take it for a spin 🌀

builtin/docker/kaniko.go Outdated Show resolved Hide resolved
internal/cli/install.go Show resolved Hide resolved
internal/cli/ondemand_runner_apply.go Show resolved Hide resolved
internal/cli/ondemand_runner_apply.go Outdated Show resolved Hide resolved
internal/cli/ondemand_runner_list.go Outdated Show resolved Hide resolved
internal/cli/ondemand_runner_list.go Outdated Show resolved Hide resolved
Co-authored-by: Brian Cain <bcain@hashicorp.com>
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants