This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 327
Introduce On-Demand Runners #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
reviewed
Aug 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing the rest of this now...but figured I'd comment on these now since it's not entirely related to the rest of the PR reivew 😄
Co-authored-by: Brian Cain <bcain@hashicorp.com>
briancain
suggested changes
Aug 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more code review! ✨ This looks cool 😎 excited to take it for a spin 🌀
Co-authored-by: Brian Cain <bcain@hashicorp.com>
waypoint on-demand runner inspect and small copy changes
mitchellh
reviewed
Aug 23, 2021
mitchellh
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR and so I suggest reading it a commit at a time rather than all at once. The commits are sequenced and cohesive as standalone changes.
This change corresponds with a plugin-sdk PR as well: hashicorp/waypoint-plugin-sdk#56
This builds on the task plugin work to add the concept on an ondemand runner (or ODR). This commit covers 4 main areas: