Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: Fixed input vars + git settings overwriting bug #2057

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

sabrinako
Copy link
Contributor

Closes #2040 (check issue for further description of bug behavior)

How to test

  1. Pull down branch
  2. Start up a local Waypoint server
  3. waypoint ui -authenticate and proceed to localhost to approve cert authority
  4. cd ui and ember serve local
  5. Go to localhost:4200
  6. Test these various situations:
  • Create project with an attached git repo, add input variables, edit git settings again
  • Create project without git repo, add input variables
  • Add, edit, delete input variables
  • Try all 3 of the authentication methods settings (user, ssh, none)
  • Ensure SSH keys and server-based HCL files show up as expected

Copy link
Contributor

@gregone gregone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sabrinako. Thanks for extracting the upsert logic into the api service 👍 . I only have a question about the authcase value.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving input variables erases project settings + vice versa
2 participants