This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
cli/status: Add a '-refresh' flag to regenerate project applications status on request #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new flag, `-refresh`, which will refresh all of the requested status reports for the current view from running `waypoint status`. This means if you refresh a refresh for a project view, all of that projects applications will be refreshed. If you request a single app, only that app will be refreshed, etc.
This commit adds a new package for CLI callers to watch an already queued jobs output and stream it directly to the configured UI terminal.
izaaklauer
reviewed
Aug 23, 2021
mitchellh
suggested changes
Aug 23, 2021
There was a problem hiding this comment.
I think my big comments here is that the CLI subcommand is painfully aware and logic-divergent on whether this is "local" or "remote". All our other tasks also have this distinction, but this is handled at the CLI layer (does it go to a local runner, or remote?).
My opinion is that the CLI implementation should probably just schedule a status report refresh job no matter what and let the local vs remote runner handle that properly. The machinery all gets wired through automatically. This is how every other operation works afaik.
krantzinator
suggested changes
Aug 23, 2021
Co-authored-by: Rae Krantz <8461333+krantzinator@users.noreply.github.com>
No longer required
briancain
force-pushed
the
feat/cli/status-refresh
branch
from
136d2ec
to
66c50b6
Compare
briancain
force-pushed
the
feat/cli/status-refresh
branch
from
66c50b6
to
d7a4939
Compare
This commit introduces a new CLI option, WithOptionalApp, which allows CLIs like `status` to optionally be initialized with a config and a project client without a hard requirement on an app existing. It now uses DoApp directly to run a status report job. If the project is remote, and the CLI is not inside the project dir, it sets the ref app for the project client to use when queueing the status report job.
briancain
force-pushed
the
feat/cli/status-refresh
branch
from
d7a4939
to
62a00c0
Compare
izaaklauer
reviewed
Aug 24, 2021
| @@ -101,6 +102,15 @@ func (c *StatusCommand) Run(args []string) int { | |||
| c.ui.Output(wpAppFlagAndTargetIncludedMsg, terminal.WithWarningStyle()) | |||
| } | |||
|
|
|||
| // Optionally refresh status | |||
| if c.flagRefreshAppStatus { | |||
| if err := c.RefreshApplicationStatus(projectTarget, appTarget); err != nil { | |||
There was a problem hiding this comment.
Potential optimization: if they specify a -app flag, we don't need to refresh status on every app in the project.
There was a problem hiding this comment.
That should happen already!
mitchellh
approved these changes
Aug 24, 2021
krantzinator
approved these changes
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new flag,
-refresh, which will refresh all of the requested status reports for the current view from runningwaypoint status. This means if you refresh a refresh for a project view, all of that projects applications will be refreshed. If you request a single app, only that app will be refreshed, etc.