Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

plugin/nomad: only use non-empty job.StatusDescription for HealthMessage #2093

Merged
merged 2 commits into from
Aug 24, 2021
Merged

plugin/nomad: only use non-empty job.StatusDescription for HealthMessage #2093

merged 2 commits into from
Aug 24, 2021

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented Aug 23, 2021 •
edited
Loading

Why the change?

Closes #2069

What’s the plan?

  • Only assign job.StatusDescription to result.HealthMessage if non-empty
  • Verify it fixes the issue
  • Add changelog entry

What does it look like?

CleanShot 2021-08-24 at 00 01 52@2x

How do I test this?

  1. Check out the branch
  2. Deploy a nomad project
  3. Check the UI
  4. Verify that the nomad deployment status shows up as expected

@jgwhite jgwhite added bug Something isn't working plugin/nomad backport/0.5.x labels Aug 23, 2021
@jgwhite jgwhite added this to the 0.5.x milestone Aug 23, 2021
@jgwhite jgwhite requested a review from briancain August 23, 2021 22:07
@jgwhite jgwhite self-assigned this Aug 23, 2021
@jgwhite jgwhite changed the title plugin/nomad: only use non-empty job.StatusDescription for HealthMessage plugin/nomad: only use non-empty job.StatusDescription for HealthMessage Aug 23, 2021
briancain
briancain approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix @jgwhite ! 😄

@jgwhite jgwhite merged commit f6acbf3 into main Aug 24, 2021
@jgwhite jgwhite deleted the plugin-nomad/health-message-bugfix branch August 24, 2021 15:49
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request Aug 24, 2021
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

Assignees

@jgwhite jgwhite

Labels
bug Something isn't working plugin/nomad plugin
Projects
None yet
Milestone
0.5.x
Development

Successfully merging this pull request may close these issues.

Wrong status shown in tooltip for deployment on Nomad
2 participants
@jgwhite @briancain