Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: Leaky state in project settings form #2150

Closed
jgwhite opened this issue Aug 26, 2021 · 3 comments · Fixed by #2250
Closed

ui: Leaky state in project settings form #2150

jgwhite opened this issue Aug 26, 2021 · 3 comments · Fixed by #2250
Assignees
Labels
bug Something isn't working ui
Milestone

Comments

@jgwhite
Copy link
Contributor

jgwhite commented Aug 26, 2021

Describe the bug
Values entered in the project settings form appear to “leak” between different projects. This is a UI-only problem.

Steps to Reproduce
There are probably a few ways to reproduce this, but is the one I had to hand:

  1. Create a new project (with “connect a repository” checked)
  2. Enter valid repo details and save
  3. Return to “Projects”
  4. Create another project (also with “connect a repository” checked)
  5. Observe that the fields erroneously contain the data from the first project
CleanShot.2021-08-26.at.15.56.02.mp4

Expected behavior
The fields should be in their default empty state. Data should not appear to “leak” between projects.

Waypoint Platform Versions

  • Waypoint Version: 0.5.1
@jgwhite jgwhite added bug Something isn't working ui new labels Aug 26, 2021
@evanphx evanphx removed the new label Sep 1, 2021
@evanphx evanphx added this to the 0.5.x milestone Sep 1, 2021
@krantzinator
Copy link
Contributor

krantzinator commented Sep 2, 2021

Disregard this comment! It's a separate issue.

@koesbong
Copy link

koesbong commented Sep 2, 2021

This may be a regression because a similar issue was created before and solved in this PR.

@krantzinator
Copy link
Contributor

An additional piece here is, if you select Enable automated deployment on changes, then the Waypoint server freezes and it is impossible to add new projects via the UI.
This might be a completely separate issue or related, let me know if I should make a separate issue here.

Here's a gist of the full stack trace when I SIGQUIT a stuck command after I do the above: https://gist.github.com/krantzinator/d1907654759d22ffb8184d02c8b067a0

For ease of seeing the most relevant bits, Ctrl+F and search for waypoint and select the Highlight All option next to the search box.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants