internal/server: Add many validations to authenticated endpoints #2273
Conversation
Prior to this commit, an empty request body would panic the server if this endpoint received a bad request.
This commit adds API validations for GetProject and UpsertApplication requests.
There was a problem hiding this comment.
Looks air-tight to me. I tested it quickly against the web UI and the errors come through pretty nicely:
(In reality you can’t submit the form without entering something in the name field, so users shouldn’t ever get into this state, but useful to see what these validation messages look like in general)
internal/server/ptypes/project.go
Outdated
| )) | ||
| } | ||
|
|
||
| // ValidateGetProjectRequest |
There was a problem hiding this comment.
[sand] This comment doesn’t match the function below it. But also: these comments don’t add much, could we drop them altogether?
There was a problem hiding this comment.
Oops, yeah probably from all the copy paste to get the bare functions around before adding the content :D I can just fix the comment.
There was a problem hiding this comment.
If I were to do this again I'd probably delete them but now that they are there I'll probably leave them be 😅
This pull request adds many validations to various authenticated endpoints that would panic if given an empty request body.
Fixes #2270