This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/clicontext: default to gRPC port for login addr #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we would not set a port at all, and I'm not sure what port it was trying to connect to. Given our installation method on all platforms defaults our gRPC to port 9701, it makes sense to default to port 9701 if none is specified. This makes the initial installation login experience smoother cause most installations can just do: $ waypoint login <IP or hostname> And it'll just work, rather than looking up the port, which is most likely 9701.
mitchellh
added
the
pr/no-changelog
mitchellh
removed
the
pr/no-changelog
briancain
reviewed
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we would not set a port at all, and I'm not sure what port it was
trying to connect to. Given our installation method on all platforms
defaults our gRPC to port 9701, it makes sense to default to port 9701
if none is specified.
This makes the initial installation login experience smoother cause most
installations can just do:
And it'll just work, rather than looking up the port, which is most
likely 9701.