ui: Add Docker image/tag information and Overview section #2352

sabrinako · 2021-09-24T20:54:25Z

#1520

Original UI

Updated UI

How to Test

Pull this branch down ui/docker-version
Run a local Waypoint server (see here)
Create a project
waypoint up
Check the deployment details page

jgwhite · 2021-10-01T10:14:17Z

What this looks like when the status report is still pending:

internal/server/gen/server.pb.go

jgwhite · 2021-10-01T11:24:31Z

ui/app/components/container-image-tag/index.ts

+ return;
+ }
+
+ let container = this.args.statusReport.resourcesList.find((r) => r.type === 'container');


I’m realizing that this method of digging up the image reference isn’t general enough. On the resource detail page (which I wrote) it only works for Kubernetes pods, and here it only works for Docker containers. We should collaborate on a general approach to this.

I tried traversing everything in statusReport.resourcesList in search of image fields. This does get us what we want, but also some stuff we don’t want.

Here’s roughly what that approach would look like: cfbef23

ui/app/components/meta-table/index.hbs

ui/app/components/meta-table/index.ts

jgwhite · 2021-10-01T12:48:02Z

By the way: I love how you’ve structured the “How to test” instructions. Going to steal that format going forward. Hope you don’t mind!

ui/app/components/meta-table/index.ts

gregone

LGTM, just one minor comment

ui/app/components/container-image-tag/index.ts

jgwhite

Looking good. Just a few minor suggestions.

ui/app/components/container-image-tag/index.ts

jgwhite · 2021-10-04T12:10:10Z

ui/tests/integration/components/status-report-meta-table-test.ts

+module('Integration | Component | meta-table', function (hooks) {
+ setupRenderingTest(hooks);
+
+ test('it renders', async function (assert) {


I’d be tempted to split this test in two: one for the happy path and one for the empty state.

jgwhite · 2021-10-04T12:10:37Z

ui/app/components/status-report-meta-table/index.hbs

@@ -0,0 +1,29 @@
+<div class="artifact-overview">


There are a few localizable strings in this file. Could we add them to en-us.yaml?

jgwhite

🥳

- added beginning HTMLElements for overview table component - no tests

ui: added tests for MetaTable+ContainerImageTag ui: added changelog ui: fixed small bug ui: account for duplicate image key ui: fix failing tests from previous commit

Co-authored-by: Jamie White <jamie@jgwhite.co.uk>

@jgwhite

much of the logic was written by @jgwhite in commit cfbef23 Co-authored-by: Jamie White <jamie@jgwhite.co.uk>

Co-authored-by: Jamie White <jamie@jgwhite.co.uk>

sabrinako added ui pr/no-changelog No automatic changelog entry required for this pull request labels Sep 24, 2021

sabrinako added this to the 0.6.0 milestone Sep 24, 2021

sabrinako self-assigned this Sep 24, 2021

sabrinako removed the pr/no-changelog No automatic changelog entry required for this pull request label Sep 24, 2021

sabrinako force-pushed the ui/docker-version branch from 8ff4f60 to 07309f8 Compare September 27, 2021 19:32

vercel bot temporarily deployed to Preview September 27, 2021 19:32 Inactive

sabrinako force-pushed the ui/docker-version branch from 07309f8 to 0fecfec Compare September 28, 2021 22:07

vercel bot temporarily deployed to Preview September 28, 2021 22:07 Inactive

koesbong linked an issue Sep 29, 2021 that may be closed by this pull request

Display Docker Image Version #1520

Closed

sabrinako force-pushed the ui/docker-version branch from 0fecfec to 09bd177 Compare September 29, 2021 22:25

vercel bot temporarily deployed to Preview September 29, 2021 22:25 Inactive

github-actions bot added the core label Sep 29, 2021

vercel bot temporarily deployed to Preview September 30, 2021 20:58 Inactive

vercel bot temporarily deployed to Preview September 30, 2021 20:59 Inactive

vercel bot temporarily deployed to Preview September 30, 2021 21:04 Inactive

vercel bot temporarily deployed to Preview September 30, 2021 21:22 Inactive

sabrinako changed the title ~~ui: (wip) added component for docker image/tag~~ ui: Add Docker image/tag information and Overview section Sep 30, 2021

vercel bot temporarily deployed to Preview September 30, 2021 21:45 Inactive

sabrinako force-pushed the ui/docker-version branch from 3c52c58 to dc86975 Compare September 30, 2021 21:56

vercel bot temporarily deployed to Preview September 30, 2021 21:56 Inactive

sabrinako marked this pull request as ready for review September 30, 2021 22:12

sabrinako requested review from almonk and a team September 30, 2021 22:12

jgwhite reviewed Oct 1, 2021

View reviewed changes

ui/app/components/meta-table/index.ts Outdated Show resolved Hide resolved

vercel bot temporarily deployed to Preview October 1, 2021 15:22 Inactive

vercel bot temporarily deployed to Preview October 1, 2021 18:05 Inactive

github-actions bot removed the core label Oct 1, 2021

vercel bot temporarily deployed to Preview October 1, 2021 18:13 Inactive

vercel bot temporarily deployed to Preview October 1, 2021 19:13 Inactive

gregone approved these changes Oct 4, 2021

View reviewed changes

ui/app/components/container-image-tag/index.ts Outdated Show resolved Hide resolved

jgwhite suggested changes Oct 4, 2021

View reviewed changes

vercel bot temporarily deployed to Preview October 4, 2021 21:15 Inactive

sabrinako force-pushed the ui/docker-version branch from a1a512b to 4fab0c4 Compare October 4, 2021 21:21

vercel bot temporarily deployed to Preview October 4, 2021 21:21 Inactive

sabrinako requested a review from jgwhite October 4, 2021 21:36

jgwhite approved these changes Oct 5, 2021

View reviewed changes

jgwhite mentioned this pull request Oct 5, 2021

Use enhanced OCI image lookup on resource detail page #2418

Closed

Sabrina Ko and others added 6 commits October 5, 2021 10:12

ui: added component for docker image/tag

fef42f5

- added beginning HTMLElements for overview table component - no tests

ui: added metadata overview table component

309d815

ui: updated logic, added tests, fixed bugs

34bb255

ui: added tests for MetaTable+ContainerImageTag ui: added changelog ui: fixed small bug ui: account for duplicate image key ui: fix failing tests from previous commit

Apply suggestions from @jgwhite

8a230cc

Co-authored-by: Jamie White <jamie@jgwhite.co.uk>

ui: genericized search for image key in stateJson

a615490

much of the logic was written by @jgwhite in commit cfbef23 Co-authored-by: Jamie White <jamie@jgwhite.co.uk>

ui: fixed failing tests and addressed PR comments

41a3a34

Co-authored-by: Jamie White <jamie@jgwhite.co.uk>

sabrinako force-pushed the ui/docker-version branch from 4fab0c4 to 41a3a34 Compare October 5, 2021 14:15

vercel bot temporarily deployed to Preview October 5, 2021 14:15 Inactive

sabrinako merged commit c88aa4c into main Oct 5, 2021

sabrinako deleted the ui/docker-version branch October 5, 2021 14:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ui: Add Docker image/tag information and Overview section #2352

ui: Add Docker image/tag information and Overview section #2352

sabrinako commented Sep 24, 2021 •

edited

Loading

jgwhite commented Oct 1, 2021

jgwhite Oct 1, 2021 •

edited

Loading

jgwhite Oct 1, 2021 •

edited

Loading

jgwhite commented Oct 1, 2021

gregone left a comment

jgwhite left a comment

jgwhite Oct 4, 2021

jgwhite Oct 4, 2021

jgwhite left a comment

ui: Add Docker image/tag information and Overview section #2352

ui: Add Docker image/tag information and Overview section #2352

Conversation

sabrinako commented Sep 24, 2021 • edited Loading

Original UI

Updated UI

How to Test

jgwhite commented Oct 1, 2021

jgwhite Oct 1, 2021 • edited Loading

Choose a reason for hiding this comment

jgwhite Oct 1, 2021 • edited Loading

Choose a reason for hiding this comment

jgwhite commented Oct 1, 2021

gregone left a comment

Choose a reason for hiding this comment

jgwhite left a comment

Choose a reason for hiding this comment

jgwhite Oct 4, 2021

Choose a reason for hiding this comment

jgwhite Oct 4, 2021

Choose a reason for hiding this comment

jgwhite left a comment

Choose a reason for hiding this comment

sabrinako commented Sep 24, 2021 •

edited

Loading

jgwhite Oct 1, 2021 •

edited

Loading

jgwhite Oct 1, 2021 •

edited

Loading