This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
gitrefpretty no longer requires git, works in ODR
#2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ironically I have this change locally but hadn't pushed it into a PR, but yours looks better! |
evanphx
approved these changes
Sep 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
gitrefprettyfall back to using the go-git library ifgitisn't available. We still prefergitbecause its MUCH faster for this particularly use case but we can fallback and have the same functionality if it isn't available. I also added unit tests for both functionality.This is required for ODR since our ODR image doesn't have Git.