Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: Release Resources #2386

Merged
merged 6 commits into from
Oct 4, 2021
Merged

ui: Release Resources #2386

merged 6 commits into from
Oct 4, 2021

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented Sep 29, 2021

Why the change?

Closes #2386

What’s the plan?

  • Add resource list to release detail page
  • Add release resource detail page
  • Add release resources to deployment detail page
  • Add suitable demo data to default mirage scenario

What does it look like?

CleanShot.2021-10-01.at.00.05.42.mp4

How do I test it?

Using Mirage

  1. Check out the branch:
    git checkout ui/release-resources
  2. Boot the dev server
    cd ui && ember serve
  3. Visit the app
  4. Browse different releases and deployments
  5. Verify that when resources are available they render correctly
  6. Verify that when resources aren’t available the empty state makes sense

For realsies

  1. Check out the branch:
    git checkout ui/release-resources
  2. Build the ember app
    (cd ui && make)
  3. Bundle the static assets
    make static-assets
  4. Build the dev server
    make docker/server
  5. Build the CLI
    make bin
  6. Install waypoint on your platform of choice, i.e.
    ./waypoint install -platform=kubernetes -accept-tos -k8s-server-image=waypoint:dev -k8s-odr-image=waypoint-odr:dev
  7. Open the UI
    ./waypoint ui -authenticate
    
  8. Try out an example app of your choice (i.e. kubernetes/nodejs)
  9. Browse different releases and deployments
  10. Verify that when resources are available they render correctly
  11. Verify that when resources aren’t available the empty state makes sense

@jgwhite jgwhite added the ui label Sep 29, 2021
@jgwhite jgwhite added this to the 0.6.0 milestone Sep 29, 2021
@jgwhite jgwhite self-assigned this Sep 29, 2021
@github-actions github-actions bot removed the ui label Sep 29, 2021
@jgwhite jgwhite linked an issue Sep 29, 2021 that may be closed by this pull request
@github-actions github-actions bot added the ui label Sep 29, 2021
@jgwhite jgwhite requested a review from a team September 30, 2021 22:09
@jgwhite jgwhite marked this pull request as ready for review September 30, 2021 22:09
class="resources-table"
class="
resources-table
{{if @withMargin "resources-table--with-margin"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this withMargin related to the styling when used within a Section component? if so, wouldn't it be simpler to style this within the styles/component/section.scss file as a descendent selector?

Unless of course you foresee the table needing this elsewhere too... in that case, disregard my comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit I hadn’t considered using a descendent selector. But yeah, I can see the table needing this in other situations. This is where a mb-4 utility class would be handy.

Copy link
Contributor

@gregone gregone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a minor question about the approach to styling

@jgwhite jgwhite merged commit 0b86e98 into main Oct 4, 2021
@jgwhite jgwhite deleted the ui/release-resources branch October 4, 2021 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Resources
2 participants