This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Papercuts in kubernetes server install #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
izaaklauer
commented
Oct 4, 2021
izaaklauer
commented
- Fixes a problem where deployments would be marked as "Degraded", but were actually fine
- Adds a new clusterrole and clusterrolebinding to the install flow to allow the runner to get and list nodes, which it needs to discover the IP of nodeport type services.
- If for some reason the nodeport ip discovery fails, don't fail the whole release (per @evanphx 's suggestion)
krantzinator
approved these changes
Oct 4, 2021
briancain
suggested changes
Oct 4, 2021
briancain
approved these changes
Oct 5, 2021
catsby
approved these changes
Oct 5, 2021
| // Print in a standalone step, so the output won't get overwritten if we add more step output later in the future. | ||
| errStep := sg.Add("Cannot determine release URL for nodeport service due to failure to list nodes: %s", err) | ||
| errStep.Status(terminal.StatusError) | ||
| errStep.Done() |
There was a problem hiding this comment.
nit: should we use the included log here and log this error as well? I don't see log used much (or at all?) in this method, but if we're not returning the error we may only be showing it in a UI in this case, right? Just a thought, as mentioned I don't see log used much in this method anyway
There was a problem hiding this comment.
There are a bunch of places where I think ui messages would be super helpful in logs - honestly, i've been meaning to solve this eventually with #2075, so i've been reticent to duplicate messages between ui and the logs. If you think this is an especially important one though, I can see putting a log here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.