This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
UI: fix config var renaming #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR taught me the word “unicity”! Thank you! |
izaaklauer
pushed a commit
that referenced
this pull request
Oct 8, 2021
* delete renamed var after edition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2339
Because the API does an upsert for config vars, and unicity is enforced via variable names, renaming a variable would cause the creation of a new variable. This PR adds logic to compare the updated variable name with the original one, and deletes the initial variable after save if the name has been changed.