cli: set project on cfg

[krantzinator]

Fixes #2523

Also closes #2525; Izaak and I chatted in Slack about preferring this strategy.

[izaaklauer]

I wonder if there are any commands that check if that project ref is nil, and do some project-agnostic thing if so - maybe status? I'll test.

[briancain]

Gave this a shot with waypoint status, waypoint logs, and waypoint exec and it works as expected!

[izaaklauer]

I think that this block will never trigger now:

waypoint/internal/cli/base.go

Lines 398 to 409 in c962b46

	if baseCfg.ProjectTargetRequired {
	if c.refProject == nil {
	if len(c.cfg.Project) == 0 {
	c.ui.Output(errProjectMode, terminal.WithErrorStyle())
	return ErrSentinel
	}
	c.refProject = &pb.Ref_Project{
	Project: c.cfg.Project,
	}
	}
	}

[krantzinator]

I think that this block will never trigger now:

waypoint/internal/cli/base.go

Lines 398 to 409 in c962b46

	if baseCfg.ProjectTargetRequired {
	if c.refProject == nil {
	if len(c.cfg.Project) == 0 {
	c.ui.Output(errProjectMode, terminal.WithErrorStyle())
	return ErrSentinel
	}
	c.refProject = &pb.Ref_Project{
	Project: c.cfg.Project,
	}
	}
	}

Yeah, 'cause we load the config earlier on and fail if it's not there before checking on flagProject. I'll remove it.

[izaaklauer]

Without this, running waypoint exec bin/bash causes a panic.

Even with this, it's not great behavior, because it parses bin as the project and bash as the app, but it's the same behavior as 0.5.2 and we can address it later.

[mitchellh]

Huh, I wonder when this started happening. I'd be curious to run a bisect and figure out what caused this because this obviously didn't crash at some point. I don't use the exec or logs commands often so it could be awhile, but I'm curious from a learning perspective what caused this.

[krantzinator]

Huh, I wonder when this started happening. I'd be curious to run a bisect and figure out what caused this because this obviously didn't crash at some point. I don't use the exec or logs commands often so it could be awhile, but I'm curious from a learning perspective what caused this.

This started happening after #2413 . So we are fixing a couple of logic pathways from that. Some of the if logic statements weren't all encompassing.