This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Remove img, push a pure on-demand runner build instead. #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Waypoint 0.6, we support on-demand runners that use Kaniko for Dockerless builds in unprivileged environments. Configuring runners to use `img` was always advanced and error-prone and sometimes impossible in certain hosted environments. For Waypoint 0.7, this removes img completely.
izaaklauer
approved these changes
Oct 20, 2021
|
Alright, TODO is to add ODR support to Nomad before 0.7, but that should be no problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Waypoint 0.6, we support on-demand runners that use Kaniko for
Dockerless builds in unprivileged environments. Configuring runners to
use
imgwas always advanced and error-prone and sometimes impossiblein certain hosted environments.
For Waypoint 0.7, this removes img completely. This isn't extremely well tested
yet, but I propose just merging this to main and letting it stew a bit as we work on
and develop other features to ensure that this is all safe.
This keeps all the img stuff in Git history in case we ever need to access it again.