This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
serverinstall/nomad: Automatically setup Consul service on install #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Prior to this commit, the consul service integration was an optional opt-in service that users could request when using the server install helper CLI with Nomad. This commit changes that by instead setting up the Consul service automatically, given how many Nomad workflows require Consul for any kind of networking.
briancain
force-pushed
the
serverinstall/nomad/require-consul
branch
from
eb87cc6
to
b658c3d
Compare
This commit updates the CLI install helper to always retry the server connection before moving on. This gives the CLI some wiggle room for the server to start up, along with any custom dns that might take a while to get responsive.
This commit updates the Waypoint Nomad allocation to use a reserved port rather than dynamic. That means we can always know the port even if the allocation gets restarted for any reason.
briancain
commented
Oct 29, 2021
Give a hint as to why the CLI is failing to connect to the server directly in the retry ui stepgroup
evanphx
reviewed
Nov 1, 2021
evanphx
approved these changes
Nov 1, 2021
mitchellh
approved these changes
Nov 1, 2021
|
Sounds good, I think we're overdue for a proper |
|
Going to backport this, and when I fixup the server install docs, I'll be sure to include a note about server upgrades and the consul requirement change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the consul service integration was an optional
opt-in service that users could request when using the server install
helper CLI with Nomad. This commit changes that by instead setting up
the Consul service automatically, given how many Nomad workflows require
Consul for any kind of networking.