This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix issue where you can't disable Project polling #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catsby
added
the
pr/no-changelog
|
Thanks @evanphx for teaching me the pointer magic here :D |
catsby
added
core/cli
and removed
pr/no-changelog
briancain
approved these changes
Nov 3, 2021
izaaklauer
approved these changes
Nov 4, 2021
|
Should this have been backported @catsby ? You can still backport by applying the label once it's merged, if so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with
waypoint project apply, users need to provide several flags in order to enable git or app status polling. Two flags are problematic (flagPollandflagAppStatusPoll) because they are declared asboolvalues, and our flag parsing package cannot discern between afalseboolean value supplied versus the zero valuefalseif either flag is simply omitted. That, coupled with a logical truthy check, currently prevent users from turning either polling or app status polling off with the CLI once they are enabled (users can still disable git polling from the UI).This PR adds a new flag value
BoolPtrVar, for boolean values that need to discern betweentrue,false, and omitted.BoolPtrVaris a*boolvalue which contains a pointer totrue,false, ornil. There is no default value (or you could saynilis the default). This enables users to omit the flag and not have that be interpreted as supplyingfalse.Fixes #2037
Supersedes #2610