Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

UI/OIDC auth #2688

Merged
merged 16 commits into from
Nov 10, 2021
Merged

UI/OIDC auth #2688

merged 16 commits into from
Nov 10, 2021

Conversation

gregone
Copy link
Contributor

@gregone gregone commented Nov 5, 2021

Closes #2390

This PR adds the OIDC Authentication flow to the browser UI.

The docs and Go references to auth links have been updated to reflect the new auth/oidc-callback URL.

@gregone gregone marked this pull request as ready for review November 9, 2021 18:27
@gregone gregone requested review from a team November 9, 2021 18:27
Copy link
Contributor

@jgwhite jgwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I added a few questions and suggestions but the overall architecture is spot on.

ui/app/authenticators/oidc.ts Outdated Show resolved Hide resolved
ui/app/components/oidc-auth-buttons/index.ts Outdated Show resolved Hide resolved
ui/app/components/oidc-auth-buttons/index.ts Outdated Show resolved Hide resolved
ui/app/routes/auth/index.ts Outdated Show resolved Hide resolved
ui/app/routes/auth/oidc-callback.ts Show resolved Hide resolved
ui/mirage/models/auth-method.ts Outdated Show resolved Hide resolved
Co-authored-by: Jamie White <jamie@jgwhite.co.uk>
@gregone
Copy link
Contributor Author

gregone commented Nov 10, 2021

@jgwhite comments addressed in 457c623

@gregone gregone merged commit 454eec0 into main Nov 10, 2021
@gregone gregone deleted the ui/oidc-auth branch November 10, 2021 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI OIDC Authentication
2 participants