Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Add Workspace Create command #2797

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Add Workspace Create command #2797

merged 4 commits into from
Dec 14, 2021

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Dec 3, 2021

This PR adds a simple workspace create <name> CLI command for creating workspaces with the UpsertWorkspace endpoint.

Workspaces are a bit limited at the moment, so there really isn't much to do here. The Upsert API call does not currently indicate if the workspace already existed or not, so we simply display the same generic "registered with server" response.

@catsby catsby added the pr/no-changelog No automatic changelog entry required for this pull request label Dec 3, 2021
@github-actions github-actions bot added the core label Dec 3, 2021
@catsby catsby added cli and removed pr/no-changelog No automatic changelog entry required for this pull request labels Dec 3, 2021
@catsby catsby requested a review from a team December 3, 2021 19:37
internal/cli/workspace_create.go Outdated Show resolved Hide resolved
internal/cli/workspace_create.go Outdated Show resolved Hide resolved
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Clint! Just a few minor comments from me 👍🏻

internal/cli/workspace_create.go Outdated Show resolved Hide resolved
internal/cli/workspace_create.go Outdated Show resolved Hide resolved
internal/cli/workspace_create.go Outdated Show resolved Hide resolved
catsby and others added 4 commits December 13, 2021 16:58
Co-authored-by: Brian Cain <bcain@hashicorp.com>

Update internal/cli/workspace_create.go

Co-authored-by: Brian Cain <bcain@hashicorp.com>

remove sprintf

Update internal/cli/workspace_create.go

Co-authored-by: Brian Cain <bcain@hashicorp.com>
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the updates 👍🏻

@catsby catsby merged commit 342e2b4 into main Dec 14, 2021
@catsby catsby deleted the cli-workspace-create branch December 14, 2021 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants