Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

cli: Requires -app flag if config set -scope=app is set. #3040

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

xiaolin-ninja
Copy link
Contributor

@xiaolin-ninja xiaolin-ninja commented Feb 23, 2022

Currently, if the scope is set explicitly as "app" without an app provided, we set the scope with an empty app. We should return a helpful error message instead.

Before:

❯ waypoint-dev config set -scope=app tester=test

❯ waypoint-dev config get
   SCOPE  |  NAME  | VALUE | WORKSPACE | LABELS  
----------+--------+-------+-----------+---------
  project | test   | test  |           |         
  app:    | tester | test  |           |        

After:

❯ waypoint-dev config set -scope=app testt=test
-scope requires -app set if scope is 'app'

@xiaolin-ninja xiaolin-ninja added pr/no-changelog No automatic changelog entry required for this pull request backport/0.7.x labels Feb 23, 2022
@github-actions github-actions bot added the core label Feb 23, 2022
@xiaolin-ninja xiaolin-ninja changed the title Requires -app flag if -scope=app is set. Requires -app flag if config set -scope=app is set. Feb 23, 2022
@xiaolin-ninja xiaolin-ninja removed the pr/no-changelog No automatic changelog entry required for this pull request label Feb 23, 2022
@xiaolin-ninja xiaolin-ninja changed the title Requires -app flag if config set -scope=app is set. fix/cli: Requires -app flag if config set -scope=app is set. Feb 23, 2022
@xiaolin-ninja xiaolin-ninja changed the title fix/cli: Requires -app flag if config set -scope=app is set. cli: Requires -app flag if config set -scope=app is set. Feb 23, 2022
@xiaolin-ninja xiaolin-ninja merged commit 8096506 into main Feb 24, 2022
@xiaolin-ninja xiaolin-ninja deleted the bug/config_set_scope branch February 24, 2022 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants