feat: pass docker arch to ecr to lambda #3046
Conversation
builtin/docker/plugin.proto
Outdated
|
|
||
| // Waypoint 0.6 and earlier supported "img" as a Dockerless builder. | ||
| // We removed this in 0.7, hence we prefix this now with "unused". We | ||
| // keep the field around so we can detect old clients sending it and | ||
| // show an error. Do not set this. | ||
| google.protobuf.Empty unused_img = 5; | ||
| google.protobuf.Empty unused_img = 6; |
There was a problem hiding this comment.
if I remember right, these numbers should never be changed. Otherwise old proto clients will use the wrong variables during communication. It's totally fine to make architecture the next number here, no need to bump the other ones.
There was a problem hiding this comment.
Ah TIL! and that makes sense
builtin/aws/lambda/mapper.go
Outdated
| log.Warn("unsupported docker architecture", "arch", src, "defaulting to:", lambda.ArchitectureX8664) | ||
| return lambda.ArchitectureX8664 |
There was a problem hiding this comment.
This could just be the default case in the switch
thiskevinwang
force-pushed
the
kw/feat-docker-arch
branch
from
59108a2
to
59249dd
Compare
thiskevinwang
force-pushed
the
kw/lambda-arm64
branch
from
c89f0db
to
749d1da
Compare
thiskevinwang
force-pushed
the
kw/feat-docker-arch
branch
from
1787958
to
d007daa
Compare
builtin/aws/lambda/mapper.go
Outdated
| @@ -0,0 +1,19 @@ | |||
| package lambda | |||
There was a problem hiding this comment.
Could you move this to utils.go instead? Mappers are a specific argmapper concept that are automatically called and have to be registered. This appears to just be a helper function to convert one string to another.
There was a problem hiding this comment.
TIL! Ok, renamed this mapper.go file utils.go
Description
This adds
dockerarchitecture, and passes it to theecrcomponent and thenlambdacomponent (via the protobufs) for a 0-config option to automatically set a lambda architecture that is compatible with the ECR image architecture.The HCL value from #3032 takes precedence.
This closes #3026