This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/{server,cli}: Attempt to forcefully cancel a job #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
added
the
pr/no-changelog
briancain
removed
the
pr/no-changelog
This commit exposes the `force` option for forcefully canceling a job in Waypoint. The `force` option already existed at the state level, including unit tests, so this commit simply exposes the `force` option at the API level and introduces a flag in the CLI.
briancain
force-pushed
the
server/core/add-force-param-to-cancel-job
branch
from
604afbc
to
f34120c
Compare
mitchellh
suggested changes
Mar 15, 2022
Force canceling a job can be very dangerous. This commit updates the flag name and the corresponding docs and CLI UX around it to reflect how dangerous it can be to force cancel.
mitchellh
approved these changes
Mar 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes the
forceoption for forcefully canceling a job inWaypoint. The
forceoption already existed at the state level,including unit tests, so this commit simply exposes the
forceoptionat the API level and introduces a flag in the CLI.