Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

runner list shows runner labels #3133

Merged
merged 2 commits into from
Mar 23, 2022
Merged

runner list shows runner labels #3133

merged 2 commits into from
Mar 23, 2022

Conversation

xiaolin-ninja
Copy link
Contributor

@xiaolin-ninja xiaolin-ninja commented Mar 23, 2022 •
edited
Loading

Adds a "labels" column in runner list.

❯ waypointdev runner list
              ID             |   STATE    |  KIND  |          LABELS           | LAST REGISTERED  
-----------------------------+------------+--------+---------------------------+------------------
  prod-static                | adopted    | remote |                           | 1 month ago      
  dev-static                 | preadopted | remote |                           | 1 week ago       
  01FYT7AKV1QNPDYKE1WNH87TH4 | preadopted | remote | region:testland env:test  | 5 seconds ago

@github-actions github-actions bot added the core label Mar 23, 2022
@xiaolin-ninja xiaolin-ninja added this to the 0.8.0 milestone Mar 23, 2022
@xiaolin-ninja xiaolin-ninja linked an issue Mar 23, 2022 that may be closed by this pull request
feature: targetable runners #2866
Closed
mitchellh
mitchellh approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, small chunk PRs are great, too!

@xiaolin-ninja xiaolin-ninja merged commit 8a3b25b into main Mar 23, 2022
@xiaolin-ninja xiaolin-ninja deleted the cli/runner-list branch March 23, 2022 18:02
briancain
briancain reviewed Mar 23, 2022
View reviewed changes
.changelog/3133.txt
Comment on lines +1 to +2
```
release-note:improvement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to be inline with the backticks for go-changelog to be happy? Maybe you could just make the change to the txt and push it directly?

@xiaolin-ninja xiaolin-ninja mentioned this pull request Mar 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain left review comments

@mitchellh mitchellh mitchellh approved these changes

@izaaklauer izaaklauer izaaklauer approved these changes

Assignees
No one assigned
Labels
core/cli
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

feature: targetable runners
4 participants
@xiaolin-ninja @mitchellh @briancain @izaaklauer