This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Deprecate -env-vars flag in runner profile set, replace with -env-var
#3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaolin-ninja
force-pushed
the
deprecate-env-vars
branch
from
d1406f9
to
c98ecb3
Compare
xiaolin-ninja
force-pushed
the
deprecate-env-vars
branch
from
c98ecb3
to
087c999
Compare
evanphx
approved these changes
Mar 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per an internal discussion, we have decided to standardize using singular flags with
-flag=key=valueformat to define repeatable configuration variables.For example, instead of:
runner profile set -plugin-type=docker -env-vars="foo=bar,bar=baz"the new standard is:
runner profile set -plugin-type=docker -env-var=foo=bar -env-var=bar=baz