This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
chore: add lambda platform config validation - add tests #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
suggested changes
Apr 8, 2022
There was a problem hiding this comment.
Hey there! Looks pretty good to me. My main recommendation is in Go when we format strings, you can use %q for quoting. That will save you from having to escape quotes inside of a string. We also prefer quoting %q any variable values in messages to let users know in the case where that value is nil. Then it'll show up like This strings value is "" this! rather than This strings value is this! with a double space.
Otherwise looks great, love some extra config validation and tests 😄
- add tests
use `%q` over `\"%s\"` Co-authored-by: Brian Cain <bcain@hashicorp.com>
thiskevinwang
force-pushed
the
kevin/lambda-tests
branch
from
6ced6c2
to
269be1b
Compare
briancain
approved these changes
Apr 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aws-lambdaplatform config validation fortimeoutandarchitecture