This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Support remote operations for docker-pull #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanphx
suggested changes
Apr 22, 2022
briancain
reviewed
Apr 25, 2022
There was a problem hiding this comment.
Looks pretty good overall @paladin-devops - thanks for this! Most of my comments are around the StepGroup UX. I think this could tell a clearer story as to what the plugin is doing, otherwise looks great! 😄
evanphx
approved these changes
Apr 26, 2022
briancain
approved these changes
Apr 27, 2022
Co-authored-by: Evan Phoenix <evan@hashicorp.com>
Co-authored-by: Brian Cain <bcain@hashicorp.com>
Co-authored-by: Brian Cain <bcain@hashicorp.com>
Co-authored-by: Brian Cain <bcain@hashicorp.com>
…executed for the pull.
paladin-devops
force-pushed
the
b-docker-pull-remote
branch
from
097accf
to
e64363d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2780 & #3117.
Implementation is very similar to that of the Docker builder plugin, except the Dockerfile is created by this plugin & supplied to Kaniko with only a single line, containing
FROMfollowed by the image & tag.