Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

feat(aws-lambda): static_environment #3282

Merged
merged 5 commits into from
May 19, 2022
Merged

feat(aws-lambda): static_environment #3282

merged 5 commits into from
May 19, 2022

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang commented Apr 23, 2022 •
edited
Loading

Note: this PR is temporarily based off #3213 because of a bug fix that it contains to wait for the lambda config to finish updating before updating the function code.

Description

This adds static_environment to the aws-lambda deploy component

example usage

  deploy {
    use "aws-lambda" {
      region = var.region
      memory = 512
      static_environment = {
        "PORT" = "8001"
        "READINESS_CHECK_PORT" = "8001"
      }
    }
  }

Closes #2947

@thiskevinwang thiskevinwang linked an issue Apr 23, 2022 that may be closed by this pull request
AWS Lambda - support for Lambda Environment variables #2947
Closed
@briancain briancain requested a review from a team April 25, 2022 15:34
briancain
briancain approved these changes Apr 25, 2022
View reviewed changes
builtin/aws/lambda/platform.go
// Environment variables that are meant to configure the application in a static
// way. This might be control an image that has multiple modes of operation,
// selected via environment variable. Most configuration should use the waypoint
// config commands.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this doc comment! We should include it in the doc.SetField too 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a summary!

@thiskevinwang thiskevinwang force-pushed the kevin/lambda-static-environment branch from 82cee48 to 3274d9a Compare May 14, 2022 19:35
@vercel
Copy link

vercel bot commented May 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
waypoint-ui ✅ Ready (Inspect) Visit Preview May 19, 2022 at 2:51PM (UTC)

@thiskevinwang thiskevinwang force-pushed the kevin/lambda-static-environment branch from 3274d9a to fe39405 Compare May 14, 2022 19:38
Base automatically changed from kevin/lambda-storage to main May 19, 2022 14:41
@briancain briancain merged commit 308626a into main May 19, 2022
@briancain briancain deleted the kevin/lambda-static-environment branch May 19, 2022 15:02
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request May 19, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

Assignees
No one assigned
Labels
plugin/aws plugin website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Lambda - support for Lambda Environment variables
2 participants
@thiskevinwang @briancain