This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Bug fix: Patch k8s stop task to only delete the job if it had pending pods #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catsby
added
plugin/k8s
pr/no-changelog
catsby
removed
the
pr/no-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3143 introduced changes to remove pods/jobs if any of the pods were stuck in pending. As written it unintentionally introduced a bug where no pods were getting automatically cleaned up, because we always destroyed the job when
StopTaskwas called. This prevented the auto cleanup of pods via theTTLSecondsAfterFinishedsetting in the job spec.In this PR we only destroy the job if it has any pods stuck in pending, otherwise we let Kubernetes clean things up when the TTL expires.