This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
builtin/k8s/task: Explicitly set container env var for Kaniko #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if a certain version of Kaniko was used with the current latest version of Kubernetes 1.23, Kaniko would fail to detect that it was being run inside a container. This means Waypoint would then faill back to try to use Docker inside a container for the build step. This commit fixes this by setting the proper env var for Kaniko and keeps ODR remote builds working. Fixes #2984
briancain
added
pr/no-changelog
briancain
removed
the
pr/no-changelog
evanphx
approved these changes
May 9, 2022
|
@evanphx good question! I had been under the assumption the bug hasn't been fixed yet. I'll double check before merging this, because that would be a better fix. |
|
@evanphx - Doesn't look like there's any mention of addressing the open issue in the latest release of Kaniko, so I don't think upgrading will fix this. I think we'll have to watch that issue and see when it gets in a release of Kaniko, and bump the version then! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if a certain version of Kaniko was used with the
current latest version of Kubernetes 1.23, Kaniko would fail to detect
that it was being run inside a container. This means Waypoint would then
faill back to try to use Docker inside a container for the build step.
This commit fixes this by setting the proper env var for Kaniko and
keeps ODR remote builds working.
Fixes #2984