This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/datasource: git supports cloning submodules recursively #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
briancain
approved these changes
May 17, 2022
|
I've added tests and resolved all the issues with checking out a ref with different or no submodules. 😄 |
The `recurse_submodules` configuration can be set to a non-zero value to specify the maximum depth of the recursion.
mitchellh
force-pushed
the
f-git-submodule
branch
from
94fd3db
to
bb4d0d5
Compare
briancain
approved these changes
May 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recurse_submodulesconfiguration can be set to a non-zero value to specify the maximum depth of the recursion.The test verifies this does work, I'm not sure how this works if submodules change across refs significantly from HEAD. That's another test case we should probably do, but looks significantly more involved with
go-gitso I propose we just get this merged and then iterate on any issues from there.Fixes #3350