Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Delete runner profiles #3474

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Delete runner profiles #3474

merged 4 commits into from
Jun 20, 2022

Conversation

paladin-devops
Copy link
Contributor

@paladin-devops paladin-devops commented Jun 20, 2022

Adds a new command waypoint runner profile delete <id> & closes #2710.

Happy path test:

// Create runner profile
$ waypoint runner profile set -plugin-type=docker -name=docker
✓ Runner profile created

// Runner profile exists
$ waypoint runner profile list                                
Runner profiles
   NAME  | PLUGIN TYPE |            OCI URL            | TARGET RUNNER | DEFAULT  
---------+-------------+-------------------------------+---------------+----------
  docker | docker      | hashicorp/waypoint-odr:latest | *             |          

// Inspect profile
$ waypoint runner profile inspect docker                    

» Runner profile:
                   Name: docker
                     ID: 01G615WFMC9Q5BTTKE6G9ASDYK
                Default: false
                OCI URL: hashicorp/waypoint-odr:latest
            Plugin Type: docker
          Target Runner: *
  Environment Variables: map[]

// Delete profile
$ waypoint runner profile delete 01G615WFMC9Q5BTTKE6G9ASDYK   

» Runner profile deleted

// Attempt to inspect absent profile
$ waypoint runner profile inspect docker                   
! record not found for ID: docker

// Attempt to delete the profile we deleted
$ waypoint runner profile delete 01G615WFMC9Q5BTTKE6G9ASDYK
! runner profile not found

// List all profiles (output is empty because the only existing profile was deleted)
$ waypoint runner profile list                             


Copy link
Contributor

@evanphx evanphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, totally straightforward.

@paladin-devops
Copy link
Contributor Author

@evanphx just rebased off of main to resolve the merge conflict after some upstream changes happened w/the protobuf. Just re-tested locally post-merging main to my branch and it's still looking good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete waypoint runner profiles
2 participants