This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/server: Ensure task plugin is properly parsed when invoked #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, when the server install function went to json marshall its config into a k8s task config, it would translate the k8s config to be `Requested`, but the k8s platform config expected `request` and would fail to parse the profile. This commit ensures that the task runner profile properly sets request for both mem and CPU so that it can be parsed.
Note this is actually the same as what we were doing _prior_ to this previous commit, given that we were not properly parsing k8s task configs.
briancain
added
the
pr/no-changelog
briancain
removed
the
pr/no-changelog
This comment was marked as outdated.
This comment was marked as outdated.
briancain
force-pushed
the
bug/k8s/odr-runner-profile-name
branch
from
5cb5510
to
42fb1a8
Compare
briancain
force-pushed
the
bug/k8s/odr-runner-profile-name
branch
from
42fb1a8
to
8cad554
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, when the server install function went to json
marshall its config into a k8s task config, it would translate the k8s
config to be
Requested, but the k8s platform config expectedrequestand would fail to parse the profile. This commit ensures that the task
runner profile properly sets request for both mem and CPU so that it can
be parsed.
Additionally, instead of small resource limits and requests, the default
ODR profile for k8s will instead set each value to
"0", which accordingto the k8s API is the same as being unset.