This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
core/install: Add --nomad-csi-volume-name flag to install #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
suggested changes
Jul 7, 2022
This commit allows users to specify their own volume names within their CSI provider. Some cases where the upstream provider is incompatible with the default name because of limitations on their end make it so that waypoint is unable to be used within those providers. In my testing the DigitalOcean CSI provider doesn't handle capitalization of the volume's name. I suspect other providers may have different requirements which we should be able to work around since there is not an explicit requirement in the CSI spec for the names of volumes within a provider.
This commit changes the default runner name from a hard coded string to the same method for retrieving the default runner names for all other runner platforms.
demophoon
force-pushed
the
bugfix/main/csi-volume-name-flag
branch
from
68a0515
to
b879815
Compare
catsby
reviewed
Jul 8, 2022
paladin-devops
approved these changes
Jul 11, 2022
briancain
suggested changes
Jul 11, 2022
briancain
approved these changes
Jul 12, 2022
demophoon
added
the
backport/0.9.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows users to specify their own volume names within their
CSI provider. Some cases where the upstream provider is incompatible
with the default name because of limitations on their end make it so
that waypoint is unable to be used within those providers. In my testing
the DigitalOcean CSI provider doesn't handle capitalization of the
volume's name specifically within the runner ID. I suspect other
providers may have different requirements which we should be able to
work around since there is not an explicit requirement in the CSI spec
for the names of volumes within a provider.