Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

updating the waypoint destroy help description #3580

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Jul 15, 2022

Updating the waypoint destroy -h description, as previously it read only destroying resources for one app, when in fact it destroys all apps/resources in the workspace. See below:

$ waypoint up -w=test

$ kubectl get po
NAME                                                 READY   STATUS    RESTARTS   AGE
example-nodejs-metrics-sidecar-v7-6758bf9764-qvctl   2/2     Running   0          76s
test-example-nodejs-v7-54c9fb8448-mw4nw              1/1     Running   0          20s
waypoint-runner-0                                    1/1     Running   0          3h5m
waypoint-server-0                                    1/1     Running   0          3h5m

$ waypoint destroy -w=test -auto-approve
  Performing operation locally

» Destroying releases for application 'example-nodejs-metrics-sidecar'...
✓ Running release destroy v7
✓ Kubernetes client connected to https://kubernetes.docker.internal:6443 with namespace default
✓ Service deleted

» Destroying deployments for application 'example-nodejs-metrics-sidecar'...
✓ Running deployment destroy v7
✓ Kubernetes client connected to https://kubernetes.docker.internal:6443 with namespace default
✓ Deployment deleted
Destroy successful!
  Performing operation locally

» Destroying releases for application 'test-example-nodejs'...
✓ Running release destroy v7
✓ Kubernetes client connected to https://kubernetes.docker.internal:6443 with namespace default
✓ Service deleted

» Destroying deployments for application 'test-example-nodejs'...
✓ Running deployment destroy v7
✓ Kubernetes client connected to https://kubernetes.docker.internal:6443 with namespace default
✓ Deployment deleted
Destroy successful!

$ kubectl get po
NAME                READY   STATUS    RESTARTS   AGE
waypoint-runner-0   1/1     Running   0          3h7m
waypoint-server-0   1/1     Running   0          3h7m

… destroys all apps in a workspace, not just one.
@github-actions github-actions bot added the core label Jul 15, 2022
@cicoyle cicoyle requested a review from a team July 15, 2022 18:40
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but I think if you use the -app flag then it will be single app? That would be worth mentioning in the help text too!

internal/cli/destroy.go Outdated Show resolved Hide resolved
@cicoyle cicoyle merged commit ae173a5 into main Jul 18, 2022
@cicoyle cicoyle deleted the fix-destroy-help-description branch July 18, 2022 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants