Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: Fix header spacing on build/release detail pages #3614

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Conversation

amyrlam
Copy link
Contributor

@amyrlam amyrlam commented Jul 28, 2022

  • Swap out IconTile for Hds::IconTile
    • Fix visual alignment bug along the way, to have panel-header match page-header
  • Add Percy test

Resolves: #3504
Resolves part of: #3313 (IconTile swapped out everywhere except for /onboarding, which could use some Percy-ing)

Fix visual alignment bug along the way, to have panel-header match page-header
@amyrlam amyrlam added the ui label Jul 28, 2022
@amyrlam amyrlam marked this pull request as ready for review July 28, 2022 23:22
@amyrlam amyrlam requested a review from a team July 28, 2022 23:22
@amyrlam
Copy link
Contributor Author

amyrlam commented Jul 29, 2022

Thanks, I approved the Percy as is adding new screenshots. One of the other PR's will codify that the reviewer should do that

@amyrlam amyrlam merged commit 500f628 into main Jul 29, 2022
@amyrlam amyrlam deleted the ui/icon-tile branch July 29, 2022 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header spacing on build/release detail pages
2 participants