This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix VCS Git Dirty Err #3636
Merged
Fix VCS Git Dirty Err #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the beginning.
izaaklauer
suggested changes
Aug 3, 2022
| } | ||
|
|
||
| // getRemoteName queries the repo at GitDirty.path for all remotes, and then | ||
| // searches for the remote that matches the provided url, returning an error if | ||
| // no remote url is found. | ||
| // It will also attempt to match against different protocols - if an https protocol is | ||
| // specified, if it can't find an exact match, it will look for an ssh-style match (and vice-versa) | ||
| func getRemoteName(log hclog.Logger, repoPath string, remoteUrl string) (name string, err error) { | ||
| func getRemoteName(log hclog.Logger, repoPath string, wpRemoteUrl string) (name string, err error) { |
| @@ -0,0 +1,26 @@ | |||
| # Fixture Test Data | |||
There was a problem hiding this comment.
Thank you, this is excellent!
izaaklauer
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
This looks well-tested and good to me. I don't love that we have to do this much hueristics+guessing to match repo names, but this logic really all goes to feed a warning, and won't be a disaster if we discover that it doesn't work under new circumstances we haven't yet considered.
Great work on this!
catsby
reviewed
Aug 4, 2022
catsby
approved these changes
Aug 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the VCS git dirty err seen when inputing the waypoint
-git-urlas type ssh, but without the git@ prepended to the url. Updated the corresponding tests to test such a case. Updated some var names to be clearer. Added aREADME.mdto the/internal/pkd/gitdirty/testdatato better explainfrom-DOTgit.sh&to-DOTgit.sh.