Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Get logs for a specific deployment with waypoint logs #3656

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

paladin-devops
Copy link
Contributor

Closes #2637.

… deployment.

Update the logs operation with this to optionally set the GetLogStreamRequest to be a DeploymentId variation of the request. The deployment number is required to be passed by the user to get logs for a specific deployment. If it is not passed, the old behavior of logs is followed.
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Makes sense, I have some feedback on the flag, otherwise code looks good!

internal/cli/logs.go Outdated Show resolved Hide resolved
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚀

@paladin-devops paladin-devops merged commit c91d8fb into main Aug 9, 2022
@paladin-devops paladin-devops deleted the i-deployment-logs branch August 9, 2022 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot select a deployment with waypoint logs
2 participants