Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

bug: do not reset runner profile default if flag not specified #3702

Merged
merged 3 commits into from
Aug 18, 2022
Merged

bug: do not reset runner profile default if flag not specified #3702

merged 3 commits into from
Aug 18, 2022

Conversation

izaaklauer
Copy link
Contributor

@izaaklauer izaaklauer commented Aug 17, 2022 •
edited
Loading

This fixes a bug wherein if the default flag was not specified, waypoint would set default to false.

Bug behavior:

$ waypoint runner profile list
Runner profiles
         NAME        | PLUGIN TYPE |                   OCI URL                   |               TARGET RUNNER               | DEFAULT  
---------------------+-------------+---------------------------------------------+-------------------------------------------+----------
  docker             | docker      | hashicorp/waypoint-odr:latest               | *                                         | yes      

$ waypoint runner profile set -name=docker -plugin-type=docker -oci-url=hashicorp/waypoint-odr:latest

$ waypoint runner profile list
Runner profiles
         NAME        | PLUGIN TYPE |                   OCI URL                   |               TARGET RUNNER               | DEFAULT  
---------------------+-------------+---------------------------------------------+-------------------------------------------+----------
  docker             | docker      | hashicorp/waypoint-odr:latest               | *                                         |

Notice I did not tell it to stop defaulting that profile, yet it's no longer the default

New behavior:

$ waypoint runner profile list
Runner profiles
         NAME        | PLUGIN TYPE |                   OCI URL                   |               TARGET RUNNER               | DEFAULT  
---------------------+-------------+---------------------------------------------+-------------------------------------------+----------
  docker             | docker      | hashicorp/waypoint-odr:latest               | *                                         | yes      

$ waypoint runner profile set -name=docker -plugin-type=docker -oci-url=hashicorp/waypoint-odr:latest

$ waypoint runner profile list
Runner profiles
         NAME        | PLUGIN TYPE |                   OCI URL                   |               TARGET RUNNER               | DEFAULT  
---------------------+-------------+---------------------------------------------+-------------------------------------------+----------
  docker             | docker      | hashicorp/waypoint-odr:latest               | *                                         | yes

Thanks to @benedikt for the bug report

@izaaklauer izaaklauer added the backport/0.9.x Automerge PR into release/0.9.x branch after merge to main label Aug 17, 2022
@github-actions github-actions bot added the core label Aug 17, 2022
@izaaklauer izaaklauer marked this pull request as ready for review August 17, 2022 14:29
@izaaklauer izaaklauer requested a review from a team August 17, 2022 14:29
briancain
briancain approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You gotta re-gen the website markdown but otherwise this looks good to go 🚀

catsby
catsby approved these changes Aug 18, 2022
View reviewed changes
internal/cli/runner_profile_set.go
Name: "default",
Target: &c.flagDefault,
Default: false,
f.BoolPtrVar(&flag.BoolPtrVar{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay BoolPtrVar comes in handy again 😄

@izaaklauer izaaklauer force-pushed the fix-runner-profile-default-set branch from 06db2d7 to 4311d50 Compare August 18, 2022 21:22
@izaaklauer izaaklauer merged commit 3952f0c into main Aug 18, 2022
@izaaklauer izaaklauer deleted the fix-runner-profile-default-set branch August 18, 2022 21:23
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request Aug 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

@briancain briancain briancain approved these changes

@cicoyle cicoyle cicoyle approved these changes

Assignees
No one assigned
Labels
backport/0.9.x Automerge PR into release/0.9.x branch after merge to main core website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izaaklauer @catsby @briancain @cicoyle