runner install profile fixes & improvement

[paladin-devops]

[ ] Fix the ODR config for profiles created during runner install to not set the new profile as the default
[ ] Fix the ODR config for profiles created during runner install to include the runner ID in the profile name
[ ] Modify behavior of runner install to set target labels instead of target ID on the runner profile if the user provided one or more -label flags after -- during runner install. Example below :

$ waypoint runner install -platform=kubernetes -server-addr=localhost:9701 -server-tls-skip-verify -- -label=hello=paladin -label world=devops
// Successful install

$ waypoint runner profile list
Runner profiles
                  NAME                  | PLUGIN TYPE |            OCI URL            |                TARGET RUNNER                 | DEFAULT
----------------------------------------+-------------+-------------------------------+----------------------------------------------+----------
 
  kubernetes-01GBNJDBGHP7KAACB91HHPHJ0K | kubernetes  | hashicorp/waypoint:latest     | labels: {"hello":"paladin","world":"devops"} | 

[krantzinator]

Edit: I am now realizing this is not related to your PR, exactly, so lmk if I should open an issue or we can discuss separately!
Looks great! Quick question about the name we generate for the static runner profile -- isn't the static runner's ID static?

❯ wd runner profile list                                                                                                                                                 17:10:17
Runner profiles
                 NAME                  | PLUGIN TYPE |                OCI URL                 |            TARGET RUNNER            | DEFAULT
----------------------------------------+-------------+----------------------------------------+-------------------------------------+----------
 01GBNSDX79V1T8K13DSQEXBT9C            | kubernetes  | docker.io/hashicorp/waypoint-odr:0.9.1 | *                                   | yes
 kubernetes-bootstrap-profile          | kubernetes  | hashicorp/waypoint-odr:latest          | *                                   | yes

Also, why does that OCI URL list docker.io and the others -- including those resulting from runner install commands -- not include the docker.io/ prefix?

[krantzinator]

Looks fantastic, and working well for me!

[paladin-devops]

Quick question about the name we generate for the static runner profile -- isn't the static runner's ID static?

It is indeed static! However for the installation of the static runner with the server, we decided the profile would be given a name with the convention <PLUGIN_TYPE>-bootstrap-profile when the server install code was updated to work in conjunction with the changes for runner install.

Also, why does that OCI URL list docker.io and the others -- including those resulting from runner install commands -- not include the docker.io/ prefix?

This is because of the package we're using to parse the repository name for the Docker image supplied to Kubernetes for runner install, github.com/novln/docker-parser in line 148 of internal/runnerinstall/k8s.go (below). The repository and image name are parsed from the tag because they are two separate values in the Helm chart. docker.io is the default hostname, so that appears to be returned back to the caller after parsing.

odrImageRef, err := dockerparser.Parse(odrImage)

[krantzinator]

Ah, just realized the docs need to be updated now! https://www.waypointproject.io/docs/runner/profiles#viewing-runner-profiles
At least, the example of what the default runner profiles look like.

[krantzinator]

Re-approve!