-
Notifications
You must be signed in to change notification settings - Fork 330
Feature: Reattach to a pipeline run by latest or sequence id #4042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it's repeating code that's in the pipeline run
command and introduces more maintenance surface and not very dry.
If the key is so the user knows that happens to the run, there is existing waypoint job list -pipeline=<pipeline> -run=<seq>
to monitor the state of the job, or waypoint pipeline inspect -run=<seq>
for the state of previous runs.
So they could just run job get-stream
on the latest job... though I guess if the point is to re-attach them to the stream in real-time... maybe we can figure out how to extract this code so it's not repeated, or add a -reattach
command to the existing pipeline run
.
@xiaolin-ninja so the main thing this provides is being able to replay or attach to an existing pipeline run (maybe that run was invoked in the UI or automatically by the server and a CLI client wants to follow along, for example). Using I'm good with adding a |
This command will reattach the CLI to an existing pipeline run, either by the latest run, or by a specific sequence id.
17337ef
to
17c2cea
Compare
Done via c4d5c28 @xiaolin-ninja ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & looks great!
This pull request introduces a new CLI flag for
pipeline run
to enable the CLI to reattach to an existing pipeline run, either by the latest known run, or by a specific sequence id. It will attempt to reply the job ids in the order defined in the pipeline run message.Fixes #4010