This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
CLI: Fix panics in waypoint pipeline list and waypoint pipeline inspect
#4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCP Waypoint will return a pipeline run message with no populated fields when there are no runs. The CLI should guard against this and not panic if there are no jobs defined in an empty PipelineRun message.
This commit adds some extra guards around when HCP Waypoint returns empty PipelineRun messages. In this case, we got a PipelineRun message that's empty with no fields defined, so there should not be any jobs. This fix guards against that to not panic when attempting to look at the list of jobs for a given run. It also simplifies a lot of duplicated code in the inspect command.
briancain
added
pr/no-changelog
briancain
removed
the
pr/no-changelog
catsby
approved these changes
Jan 19, 2023
|
|
||
| pipelineRun = runResp.PipelineRun | ||
| } else { | ||
| pipelineRun = runs.PipelineRuns[len(runs.PipelineRuns)-1] |
There was a problem hiding this comment.
Do we need to guard on len(runs.PipelineRuns) being 0 here?
There was a problem hiding this comment.
Good idea! I added a more generic block on this further up in 0495330 since most of this code won't make any sense if a pipeline has 0 runs!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes up the CLI to guard against empty PipelineRun Job slices. It also DRYs up some duplicated code in
pipeline inspect.Fixes #4195