Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

builtin/docker/builder: Add dockerfile variable to BuilderConfig #539

Merged
merged 1 commit into from
Oct 16, 2020
Merged

builtin/docker/builder: Add dockerfile variable to BuilderConfig #539

merged 1 commit into from
Oct 16, 2020

Conversation

xsaamiir
Copy link
Contributor

@xsaamiir xsaamiir commented Oct 16, 2020

Closes #538

Add the variable Dockerfile to the BuilderConfig of the Docker Plugin to support cases where the Dockerfile is not in the root of the project.

Please let me know if you think the variable should have another name or if you think the dockerfile name shouldn't be relative to the path of the app.

@mitchellh
Copy link
Contributor

Looks great! I think in the future the only ask I'd have is to update the Docs function too. But I'll do that manually now.

@mitchellh mitchellh merged commit 0c7f025 into hashicorp:main Oct 16, 2020
@xsaamiir xsaamiir deleted the builtin/docker/builder/support-dockerfile-path branch October 16, 2020 16:10
@xsaamiir
Copy link
Contributor Author

Looks great! I think in the future the only ask I'd have is to update the Docs function too. But I'll do that manually now.

Great thanks. Sure I will make sure to update the Docs function for any future contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker(builder) plugin: Allow passing the path to a Dockerfile
2 participants