This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Updated options for ECS deploys #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying additional environment variables to the default PORT => 3000 mapping, and specifying secrets to use with the default container. I'm still trying to work out what the flow should be for a Waypoint deployment into ECS, but it seems like we have at the very least a default container that is created during the build stage.
The deployment to ECS is quite simple: a single container, on a chosen port. This allows specifying additional containers to run along side the main container which is common as a use case.
mitchellh
reviewed
Oct 17, 2020
|
Okay! This looks awesome. We're gonna change some of the HCL attribute names a bit but otherwise we're very happy with this. thank you! |
|
Great! Pleased I could contribute :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I'd like to say how excited I am about this project! As an ECS user, while there are multiple deploy tools available, I haven't found anything that feels flexible enough to meet our requirements. The hooks feel especially beneficial.
I'm really interested in the design choices around running an application because there are lots of opinionated tools that lack the flexibility we need. At the moment deploying into ECS with Waypoint assumes a bunch of stuff (single container on a specified port), and I'm assuming that this is mostly because it's an early release.
I guess my main question here is: how much flexibility between the configuration and the "assumed defaults" are going to be a feature of Waypoint? Will it be possible to deploy into a very specific ECS setup, or is the point that it will be generic to allow deployments to multiple plugins?
This pull request adds a little bit of code to increase the flexibility of the ECS plugin, to:
Appreciate this project is still super new, but I couldn't help myself diving in, particularly since it's something that could potentially solve a problem for us!