This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
install/k8s: detect kind and show warning about additional requirements #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
changed the title
evanphx
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
This is totally fine, but we should also see if there is some API and/or config we can inspect to see if there is something configured in the cluster to handle load balancing.
We can probably also look at the events on the Service and presume that, if after a minute or so there are no updates, that the cluster doesn't have a Load Balancer handler.
|
Agreed with both. One minute won't be enough on a load balancer, I just tried on AKS and DO and both took over 3 minutes to succeed, so I think we'd have to wait quite long there. On detecting KinD in a better, way, totally would love to do that but couldn't find anything! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (partially) #527
This uses a heuristic on
waypoint installto detect Kind clusters and notes to the user that it must be setup with LoadBalancer support which it does not have out of the box nor is it trivial to setup. This will surprise users less when their installs hang.We should update the docs too but I think this is useful to have in the CLI.