This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/datasource: local data should return pwd #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local datasource needs to return the pwd so that plugin discovery uses an absolute path and doesn't attempt to search by PATH (#691). This also adds validation in internal/runner that this behavior holds.
|
Btw @tomhjp in case its not clear: the reason the runner has all this job download machinery is is for remote runners which aren't quite ready yet (and therefore not documented or technically "released" though a lot of the technical implementation is there). |
|
Thanks! Have tested this locally too just to confirm.
Hah yes this did confuse me initially 😄 looks like this will enable some super cool features! |
nicholasjackson
approved these changes
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local datasource needs to return the pwd so that plugin discovery
uses an absolute path and doesn't attempt to search by PATH (#691).
This also adds validation in internal/runner that this behavior holds.
/cc @tomhjp