This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Backport of Update ECS plugin to not assign public ip on ec2_cluster into release/0.1.x #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-waypoint-bot
force-pushed
the
backport/dl-ec2cluster-no-public-ip/actually-sensible-caiman
branch
from
b0cf3d5
to
d7fa95c
Compare
mitchellh
deleted the
backport/dl-ec2cluster-no-public-ip/actually-sensible-caiman
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #724 to be assessed for backporting due to the inclusion of the label backport/0.1.x.
The below text is copied from the body of the original PR.
When using
ec2_cluster = truethere is an errorInvalidParameterException: Assign public IP is not supported for this launch type. This wraps theAssignPublicIpnetwork configuration so that on ec2_clusters this is not set to enabled.This was reported in #643, and I've experienced it myself. Without ec2_cluster = true, Fargate will be used, and this setting works.