Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Add Service Account Field to Cloud Run #850

Merged
merged 1 commit into from
Nov 28, 2020
Merged

Add Service Account Field to Cloud Run #850

merged 1 commit into from
Nov 28, 2020

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Nov 26, 2020

fixes: #764

Also I can't seem to run make gen/doc , getting the following error

protoc -I=. \
                -I=./vendor/proto/api-common-protos/ \
                --doc_out=./doc --doc_opt=html,index.html \
                ./internal/server/proto/server.proto
google/rpc/status.proto: File not found.
internal/server/proto/server.proto:10:1: Import "google/rpc/status.proto" was not found or had errors.
internal/server/proto/server.proto:403:3: "google.rpc.Status" is not defined.
internal/server/proto/server.proto:502:3: "google.rpc.Status" is not defined.
internal/server/proto/server.proto:687:7: "google.rpc.Status" is not defined.
internal/server/proto/server.proto:694:7: "google.rpc.Status" is not defined.
internal/server/proto/server.proto:583:3: "google.rpc.Status" is not defined.
internal/server/proto/server.proto:945:5: "google.rpc.Status" is not defined.
internal/server/proto/server.proto:952:5: "google.rpc.Status" is not defined.
internal/server/proto/server.proto:1045:5: "google.rpc.Status" is not defined.
internal/server/proto/server.proto:1979:5: "google.rpc.Status" is not defined.
make: *** [gen/doc] Error 1
```

@mitchellh
Copy link
Contributor

This looks good to me. Thank you!

@mitchellh mitchellh merged commit 1ab28fe into hashicorp:main Nov 28, 2020
mitchellh added a commit that referenced this pull request Nov 28, 2020
Add Service Account Field to Cloud Run
@upodroid
Copy link
Contributor Author

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request support config service account for container in CloudRun
2 participants